On Fri, Sep 21, 2007 at 02:52:12PM +1000, Stephen Rothwell wrote: > Small comments. Thanks. > I think this is redundant as if __USE_RTC() is true, you register > clocksource_rtc below. Yup you're right. > The #ifdef is redundant since if CONFIG_ISERIES is not set, > firmware_has_feature(FW_FEATURE_ISERIES) is constant 0. Ahh okay. I got too fancy for my own good. patch comming. Yours Tony linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/ Jan 28 - Feb 02 2008 The Australian Linux Technical Conference! - To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html