On Mon, 2007-09-17 at 22:20 +0200, Andi Kleen wrote: > On Monday 17 September 2007 21:38, Sven-Thorsten Dietrich wrote: > > On Mon, 2007-09-17 at 12:07 -0700, Daniel Walker wrote: > > > On Mon, 2007-09-17 at 21:00 +0200, Andi Kleen wrote: > > > > > Since it's all got "__" in the front, not good to use this method all > > > > > over .. If you just need a real spinlock best to use > > > > > DEFINE_RAW_SPINLOCK() unless your a special situation .. > > > > die_lock has been RAW for a while, see older patches... > > It's definitely not in 2.6.23-rc4-rt1 and also wasn't in the oops > trace I looked at. > > > but DEFINE_RAW or DECLARE_RAW should be used when possible. > > I disagree for the oops case. You want the simplest possible code > here. Looks like its raw for all but the x* archs. # grep die_lock * preempt-realtime-arm.patch:-DEFINE_SPINLOCK(die_lock); preempt-realtime-arm.patch:+DEFINE_RAW_SPINLOCK(die_lock); preempt-realtime-mips.patch:-static DEFINE_SPINLOCK(die_lock); preempt-realtime-mips.patch:+static DEFINE_RAW_SPINLOCK(die_lock); preempt-realtime-powerpc.patch:-DEFINE_SPINLOCK(die_lock); preempt-realtime-powerpc.patch:+DEFINE_RAW_SPINLOCK(die_lock); preempt-realtime-sh.patch:-static DEFINE_SPINLOCK(die_lock); preempt-realtime-sh.patch:+static DEFINE_RAW_SPINLOCK(die_lock); Sven > > -Andi > - To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
