Re: [PATCH] Don't sleep in oops_begin()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2007-09-17 at 20:46 +0200, Andi Kleen wrote:
> > > -static DEFINE_SPINLOCK(die_lock);
> > > +static __raw_spinlock_t die_lock = __RAW_SPIN_LOCK_UNLOCKED;
> > 
> > You mean DEFINE_RAW_SPINLOCK() maybe? Unless I'm not following what your
> > doing here..
> 
> I just copied that from tsc_sync.c.  If it's correct there it's presumably
> correct here too.
> 
> -Andi

/*
 * We use a raw spinlock in this exceptional case, because
 * we want to have the fastest, inlined, non-debug version
 * of a critical section, to be able to prove TSC time-warps:
 */
static __cpuinitdata __raw_spinlock_t sync_lock = __RAW_SPIN_LOCK_UNLOCKED;


Since it's all got "__" in the front, not good to use this method all
over .. If you just need a real spinlock best to use
DEFINE_RAW_SPINLOCK() unless your a special situation ..

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux