Re: [PATCH] RT: add clock.cycle_accumulated to vsyscall gtod update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2007-07-13 at 01:02 -0700, Sven-Thorsten Dietrich wrote:
> On Thu, 2007-07-12 at 21:14 -0700, Daniel Walker wrote:
> > 
> > It looks like your patch might be line wrapped ?
> > 
> 
> I reconstituted the patch to clear the white space damage.
> 
> - Sven
> 
> >From ghaskins@xxxxxxxxxx Thu Jul 12 21:59:46 2007
> Mime-Version: 1.0
> X-Mailer: GroupWise 7.0.2 HP
> Subject: [PATCH] RT: add clock.cycle_accumulated to vsyscall gtod update
> Date: Thu, 12 Jul 2007 21:59:46 -0600
> Message-ID: <4696C0720200005A0002776A@xxxxxxxxxx>
> From: "Gregory Haskins" <ghaskins@xxxxxxxxxx>
> To: "Ingo Molnar" <mingo@xxxxxxx>, tglx@xxxxxxxxxxxxx
> Cc: "Sven Dietrich" <SDietrich@xxxxxxxxxx>, "David Bahi" <DBahi@xxxxxxxxxx>, linux-rt-users@xxxxxxxxxxxxxxx
> Content-Type: text/plain; charset=utf-8
> Content-Disposition: inline
> X-Evolution-Source: imap://sdietrich@xxxxxxxxxxxxxxx/
> Content-Transfer-Encoding: 8bit
> 
> 2.6.22 changed the vsyscall mechanism to store a more cache-thrash
> friendly version of the gtod data.  The original gtod cache code used an
> entire struct clock + structure-copy, whereas the new code uses a
> pseudo/shadow version + explicit-copy. 
> 
> clock.cycle_accumulated was added to RT prior to 2.6.22 so the vsyscall
> code must also be updated for the port to 22.
> 
> Signed-off-by: Gregory Haskins <ghaskins@xxxxxxxxxx>
> 
> Acked-by: Sven-Thorsten Dietrich <sven@xxxxxxxxxxxxxxxxxxxxx>

Good catch!

Acked-by: John Stultz <johnstul@xxxxxxxxxx>




> --- 
> 
>  vsyscall.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux-2.6.22/arch/x86_64/kernel/vsyscall.c
> ===================================================================
> --- linux-2.6.22.orig/arch/x86_64/kernel/vsyscall.c
> +++ linux-2.6.22/arch/x86_64/kernel/vsyscall.c
> @@ -90,6 +90,7 @@ void update_vsyscall(struct timespec *wa
>  	/* copy vsyscall data */
>  	vsyscall_gtod_data.clock.vread = clock->vread;
>  	vsyscall_gtod_data.clock.cycle_last = clock->cycle_last;
> +       vsyscall_gtod_data.clock.cycle_accumulated = clock->cycle_accumulated;
>  	vsyscall_gtod_data.clock.mask = clock->mask;
>  	vsyscall_gtod_data.clock.mult = clock->mult;
>  	vsyscall_gtod_data.clock.shift = clock->shift;

-
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux