* Remy Bohmer <l.pinguin@xxxxxxxxx> wrote: > --- linux-2.6.21.orig/include/asm/futex.h 2007-04-26 05:08:32.000000000 +0200 patch format problem: never diff the asm/ files, diff the asm-arm/ files. > + local_irq_save(flags); > + > + err = get_user(uval, uaddr); is it safe to do a get_user() with irqs off? > + if (err) > + { > + local_irq_restore(flags); > + return -EFAULT; > + } (style problems. Use scripts/checkpatch.pl to verify your patches.) > + local_irq_restore(flags); is this method of atomic ops SMP-safe? Ingo - To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html