On Tue, Jun 9, 2020 at 8:08 PM Robin Murphy <robin.murphy@xxxxxxx> wrote:
>
> On 2020-06-09 15:01, Jagan Teki wrote:
> > SDHCI HISPD bits need to be configured based on desired mmc
> > timings mode and some HISPD quirks.
> >
> > So, handle the HISPD bit based on the mmc computed selected
> > mode(timing parameter) rather than fixed mmc card clock
> > frequency.
> >
> > Linux handle the HISPD similar like this in below commit,
> >
> > commit <501639bf2173> ("mmc: sdhci: fix SDHCI_QUIRK_NO_HISPD_BIT handling")
> >
> > This eventually fixed the mmc write issue observed in
> > rk3399 sdhci controller.
> >
> > Bug log for refernece,
> > => gpt write mmc 0 $partitions
> > Writing GPT: mmc write failed
> > ** Can't write to device 0 **
> > ** Can't write to device 0 **
> > error!
> >
> > Cc: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
> > Cc: Peng Fan <peng.fan@xxxxxxx>
> > Reviewed-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> > ---
> > Changes for v2:
> > - collect Jaehoon R-b
> >
> > drivers/mmc/sdhci.c | 23 +++++++++++++++--------
> > 1 file changed, 15 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
> > index 92cc8434af..280b8c88eb 100644
> > --- a/drivers/mmc/sdhci.c
> > +++ b/drivers/mmc/sdhci.c
> > @@ -594,14 +594,21 @@ static int sdhci_set_ios(struct mmc *mmc)
> > ctrl &= ~SDHCI_CTRL_4BITBUS;
> > }
> >
> > - if (mmc->clock > 26000000)
> > - ctrl |= SDHCI_CTRL_HISPD;
> > - else
> > - ctrl &= ~SDHCI_CTRL_HISPD;
> > -
> > - if ((host->quirks & SDHCI_QUIRK_NO_HISPD_BIT) ||
> > - (host->quirks & SDHCI_QUIRK_BROKEN_HISPD_MODE))
> > - ctrl &= ~SDHCI_CTRL_HISPD;
> > + if (!(host->quirks & SDHCI_QUIRK_NO_HISPD_BIT) ||
>
> Should that be "&&" rather than "||"? Otherwise this will always
> evaluate to true unless *both* quirks are set, which isn't equivalent to
> the check being removed above.
Correct, thanks for the catch. I have updated ib v3.
Jagan.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
