Hi Johan, Johan Jonker <jbx6244@xxxxxxxxx> wrote on Wed, 29 Apr 2020 10:53:30 +0200: > Hi Yifeng, > > > On Sun, Apr 26, 2020 at 06:02:44PM +0800, Yifeng Zhao wrote: > >> Documentation support for Rockchip RK3xxx NAND flash controllers > >> > >> Signed-off-by: Yifeng Zhao <yifeng.zhao@xxxxxxxxxxxxxx> > >> --- > >> > >> Changes in v5: > >> - Fix some wrong define > >> - Add boot-medium define > >> - Remove some compatible define > >> > >> Changes in v4: > >> - The compatible define with rkxx_nfc > >> - Add assigned-clocks > >> - Fix some wrong define > >> > >> Changes in v3: > >> - Change the title for the dt-bindings > >> > >> Changes in v2: None > >> > >> .../mtd/rockchip,nand-controller.yaml | 124 ++++++++++++++++++ > >> 1 file changed, 124 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > > The name of this file is based on Miquel's opinion, but the > compatibility strings, (for which robh has given a 'reviewed by' tag) in > version 4 don't fit with this format. What do you mean? Is the file name restricted somehow? I just don't want a compatible with just "nand" in it because this word is too vague as it defines: a bus, a spec, a chip, people are also confusing it with the controller and sometimes with the ECC engine too. "nfc" is okay though. Thanks, Miquèl _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
