Re: [PATCH] arm64: dts: rockchip: Fix rk3328-roc-cc sdmmcio-regulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/5/2020 2:02 PM, Robin Murphy wrote:
On 05/02/2020 6:43 pm, Peter Geis wrote:
[...]
One thing I did notice, though, is that GPIO_MUTE seems to have some
inherent coupling to the analog codec, as the value automatically goes
high when starting to play audio, and low again when stopping (but can
still be manually toggled in between). Thus unless there's some secret
to disabling that behaviour then it might not be safe to enable analog
audio on these ROC-CC boards for fear of messing up peoples' SD cards.

Robin,
Do you know if that is the SOC doing that or the drivers?

Ha, once again I hastily jump to a conclusion without fully investigating... I'm really not doing too well in this thread :)

You're absolutely right; on closer inspection rk3328_analog_output() in the codec driver is poking GRF_SOC_CON10 directly. That should be straightforward enough to sort out, phew!

Cheers,
Robin.

I've had random reports of SD problems from people using our mainline images with Armbian on RK3328, I recently enabled the audio codec since it looked like all the pieces were in place. I'll take a look at the GPIO_MUTE patchset I saw just landed.

-Tony

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux