Hi, Question for Rob Herring. See my comments at version 2. What is the reason that the non valid/existent node options supports-sd, supports-sd max-frequeency num-slots and disable-wp together with the many style issues are accepted? Thanks. On Mon, 30 Dec 2019 20:19:32 +0530, Akash Gajjar wrote: > ROCK Pi S is RK3308 based SBC from radxa.com. ROCK Pi S has a, > - 256MB/512MB DDR3 RAM > - SD, NAND flash (optional on board 1/2/4/8Gb) > - 100MB ethernet, PoE (optional) > - Onboard 802.11 b/g/n wifi + Bluetooth 4.0 Module > - USB2.0 Type-A HOST x1 > - USB3.0 Type-C OTG x1 > - 26-pin expansion header > - USB Type-C DC 5V Power Supply > > This patch enables > - Console > - NAND Flash > - SD Card > > Signed-off-by: Akash Gajjar <akash at openedev.com> > --- > Changes for v2 > - Use pwm-supply for vdd_core node instead of vi-supply > - Add USB2.0 node support > > Changes for v3 > - Use small S on dts file name > - Add missing semicolon > - Remove USB2.0 node support > > .../devicetree/bindings/arm/rockchip.yaml | 5 + > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3308-rock-pi-s.dts | 221 ++++++++++++++++++ > 3 files changed, 227 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts > Reviewed-by: Rob Herring <robh at kernel.org> _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
