On 12/16/19 10:20 AM, Johan Jonker wrote:
> Hi Akash,
>
> See commit below.
>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-S.dts b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-S.dts
>> new file mode 100644
>> index 000000000000..e5fae451c631
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-S.dts
>
>
>> +
>> +&emmc {
>> + bus-width = <4>;
>> + cap-mmc-highspeed;
>> + mmc-hs200-1_8v;
>> + supports-sd;
supports-sd is not mentioned in mmc-controller.yaml
>
>> + disable-wp;
>
> The mmc.txt didn't explicitly say disable-wp is for SD card slot only,
> but that is what it was designed for in the first place.
> Remove all disable-wp from emmc or sdio controllers.
>
>> + non-removable;
>> + num-slots = <1>;
>> + vin-supply = <&vcc_io>;
>> + status = "okay";
>> +};
>
>> +
>> +&sdmmc {
>> + bus-width = <4>;
>> + cap-mmc-highspeed;
>> + cap-sd-highspeed;
>> + max-frequeency = <150000000>;
replace max-frequeency by max-frequency
>> + supports-sd;
supports-sd is not mentioned in mmc-controller.yaml
>> + disable-wp;
>> + num-slots = <1>;
>> + pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_det &sdmmc_bus4>;
>> + card-detect-delay = <800>;
card-detect-delay is not mentioned in mmc-controller.yaml
>> + status = "okay";
>> +};
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
