Hi Sam,
Thank you for the patch.
On Mon, Dec 02, 2019 at 08:32:11PM +0100, Sam Ravnborg wrote:
> There was no users - so remove it.
> The callback was implemented in two drivers - deleted.
This looks good to me, so
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
but I'll let Thierry decide if he prefers keeping it.
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 18 ------------------
> drivers/gpu/drm/panel/panel-simple.c | 18 ------------------
> include/drm/drm_panel.h | 9 ---------
> 3 files changed, 45 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c
> index b878930b17e4..3bcba64235c4 100644
> --- a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c
> +++ b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c
> @@ -217,30 +217,12 @@ static int seiko_panel_get_modes(struct drm_panel *panel,
> return seiko_panel_get_fixed_modes(p, connector);
> }
>
> -static int seiko_panel_get_timings(struct drm_panel *panel,
> - unsigned int num_timings,
> - struct display_timing *timings)
> -{
> - struct seiko_panel *p = to_seiko_panel(panel);
> - unsigned int i;
> -
> - if (p->desc->num_timings < num_timings)
> - num_timings = p->desc->num_timings;
> -
> - if (timings)
> - for (i = 0; i < num_timings; i++)
> - timings[i] = p->desc->timings[i];
> -
> - return p->desc->num_timings;
> -}
> -
> static const struct drm_panel_funcs seiko_panel_funcs = {
> .disable = seiko_panel_disable,
> .unprepare = seiko_panel_unprepare,
> .prepare = seiko_panel_prepare,
> .enable = seiko_panel_enable,
> .get_modes = seiko_panel_get_modes,
> - .get_timings = seiko_panel_get_timings,
> };
>
> static int seiko_panel_probe(struct device *dev,
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index d6299fe6d276..e225791a6fb2 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -326,30 +326,12 @@ static int panel_simple_get_modes(struct drm_panel *panel,
> return num;
> }
>
> -static int panel_simple_get_timings(struct drm_panel *panel,
> - unsigned int num_timings,
> - struct display_timing *timings)
> -{
> - struct panel_simple *p = to_panel_simple(panel);
> - unsigned int i;
> -
> - if (p->desc->num_timings < num_timings)
> - num_timings = p->desc->num_timings;
> -
> - if (timings)
> - for (i = 0; i < num_timings; i++)
> - timings[i] = p->desc->timings[i];
> -
> - return p->desc->num_timings;
> -}
> -
> static const struct drm_panel_funcs panel_simple_funcs = {
> .disable = panel_simple_disable,
> .unprepare = panel_simple_unprepare,
> .prepare = panel_simple_prepare,
> .enable = panel_simple_enable,
> .get_modes = panel_simple_get_modes,
> - .get_timings = panel_simple_get_timings,
> };
>
> #define PANEL_SIMPLE_BOUNDS_CHECK(to_check, bounds, field) \
> diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> index 4fd61cb9eb93..c4e82b9ce586 100644
> --- a/include/drm/drm_panel.h
> +++ b/include/drm/drm_panel.h
> @@ -102,15 +102,6 @@ struct drm_panel_funcs {
> */
> int (*get_modes)(struct drm_panel *panel,
> struct drm_connector *connector);
> -
> - /**
> - * @get_timings:
> - *
> - * Copy display timings into the provided array and return
> - * the number of display timings available.
> - */
> - int (*get_timings)(struct drm_panel *panel, unsigned int num_timings,
> - struct display_timing *timings);
> };
>
> /**
--
Regards,
Laurent Pinchart
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
