On Mon, Nov 11, 2019 at 06:55:18PM +0000, Robin Murphy wrote: > Although we don't generally expect IRQs to fire for a suspended IOMMU, > there are certain situations (particularly with debug options) where > we might legitimately end up with the pm_runtime_get_if_in_use() call > from rk_iommu_irq() returning 0. Since this doesn't represent an actual > error, follow the other parts of the driver and save the WARN_ON() > condition for a genuine negative value. Even if we do have spurious > IRQs due to a wedged VOP asserting the shared line, it's not this > driver's job to try to second-guess the IRQ core to warn about that. > > Reported-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx> > Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx> > --- > drivers/iommu/rockchip-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip