On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote:
> Replace the use of the dev_err macro with the DRM_DEV_ERROR
> DRM helper macro.
The commit message should show the reason _why_ you are doing
this instead of just stating that you are doing this.
It's not that dev_err is uncommon in drivers/gpu/drm.
$ git grep -w dev_err drivers/gpu/drm | wc -l
1950
$ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l
756
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
[]
> @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev)
> }
>
> if (!dsi->cdata) {
> - dev_err(dev, "no dsi-config for %s node\n", np->name);
> + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name);
> return -EINVAL;
> }
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
