On Tue, Nov 05, 2019 at 04:08:29PM +0100, Linus Walleij wrote: > Hi Andrew, > > thanks for your patch! Thanks for the review. > > On Mon, Nov 4, 2019 at 5:39 PM Andrew Murray <andrew.murray@xxxxxxx> wrote: > > > Replace magic numbers used to describe legacy PCI IRQ interrupts > > with #define. > > > > Signed-off-by: Andrew Murray <andrew.murray@xxxxxxx> > > When I add examples I usually make sure that above the examples > are the appropriate #include files, this is becoming more important > as we convert to yaml, then you need the right includes because the > examples will get compiled. OK thanks - I can see other files in Documentation that take this approach I'll update this patch on my respin. Thanks, Andrew Murray > > With that taken into account: > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Yours, > Linus Walleij _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
