Jagan,
On 2019/10/18 上午3:07, Jagan Teki wrote:
idbloader.img name is specific to rockchip,
This is specific for rockchip, like rksd, rkspi type in mkimage, since
it's clear for what it stands for,
I think it can also used in U-Boot.
where it usually
created using rockchip tools.
No, idbloader stands for the image with idb header packaged with two
stage loader, eg. TPL+SPL
or ddr.bin+miniloader.bin, and maybe ddr.bin + SPL， TPL+miniloader.bin,
not related to rockchip tools, it can also be created with U-Boot
mkimage tool.
Since the image is created as
per U-Boot generic builds like SPL, better to follow the
generic U-Boot naming notation like other SoC's following.
Enable idbloader.img with u-boot-spl-rockchip.bin and create
the same in spl directory since it is SPL file and Makefile.spl
will clean it by default.
Cc: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
Cc: Matwey V. Kornilov <matwey.kornilov@xxxxxxxxx>
Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index ec55e0f6a4..918b5d53e0 100644
--- a/Makefile
+++ b/Makefile
@@ -887,7 +887,7 @@ ALL-y += u-boot-with-dtb.bin
endif
ifeq ($(CONFIG_ARCH_ROCKCHIP)$(CONFIG_SPL)$(CONFIG_TPL),yyy)
-ALL-y += idbloader.img
+ALL-y += spl/u-boot-spl-rockchip.bin
This idbloader including IDB header, TPL, and SPL, I don't think name it
as spl and
put it in spl directory make any sense.
I though the origin output file use postfix '.bin' and those image after
pack and can be
dd to storage directly better to use postfix '.img'.
About the clean, it will be better to be clean like other '.img' file in
the Makefile.
Thanks,
- Kever
endif
LDFLAGS_u-boot += $(LDFLAGS_FINAL)
@@ -1344,7 +1344,7 @@ endif
MKIMAGEFLAGS_u-boot-tpl.img = -n $(CONFIG_SYS_SOC) -T $(ROCKCHIP_IMG_TYPE)
tpl/u-boot-tpl.img: tpl/u-boot-tpl.bin FORCE
$(call if_changed,mkimage)
-idbloader.img: tpl/u-boot-tpl.img spl/u-boot-spl.bin FORCE
+spl/u-boot-spl-rockchip.bin: tpl/u-boot-tpl.img spl/u-boot-spl.bin FORCE
$(call if_changed,cat)
endif
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
