Re: [PATCH] drm/rockchip: Add AFBC support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear All,

As a result of my mistake I've sent this patch with an incorrect SOB chain. Please kindly disregard this patch.

@Neil: thank you for your time you spent reviewing it and answering and I'm sorry it's to no effect.
@Ezequiel, @Tomeu: I apologize to you. My mistake.

Regards,

Andrzej Pietrasiewicz


W dniu 23.09.2019 o 15:53, Neil Armstrong pisze:
On 23/09/2019 14:20, Andrzej Pietrasiewicz wrote:
From: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>

AFBC is a proprietary lossless image compression protocol and format.
It helps reduce memory bandwidth of the graphics pipeline operations.
This, in turn, improves power efficiency.

Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>
[locking improvements]
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
[squashing the above, commit message and Rockchip AFBC modifier]
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>
---
  drivers/gpu/drm/rockchip/rockchip_drm_fb.c  | 27 ++++++
  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 94 ++++++++++++++++++++-
  drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 12 +++
  drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 18 ++++
  include/uapi/drm/drm_fourcc.h               |  3 +
  5 files changed, 151 insertions(+), 3 deletions(-)


[...]

diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 3feeaa3f987a..ba6caf06c824 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -742,6 +742,9 @@ extern "C" {
   */
  #define AFBC_FORMAT_MOD_BCH     (1ULL << 11)
+#define AFBC_FORMAT_MOD_ROCKCHIP \
+	(AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 | AFBC_FORMAT_MOD_SPARSE)

This define looks useless, what's Rockchip specific here ?

Neil

+
  /*
   * Allwinner tiled modifier
   *




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux