Am Mittwoch, 28. August 2019, 17:07:37 CEST schrieb Thierry Reding: > From: Thierry Reding <treding@xxxxxxxxxx> > > regulator_get_optional() can fail for a number of reasons besides probe > deferral. It can for example return -ENOMEM if it runs out of memory as > it tries to allocate data structures. Propagating only -EPROBE_DEFER is > problematic because it results in these legitimately fatal errors being > treated as "regulator not specified in DT". > > What we really want is to ignore the optional regulators only if they > have not been specified in DT. regulator_get_optional() returns -ENODEV > in this case, so that's the special case that we need to handle. So we > propagate all errors, except -ENODEV, so that real failures will still > cause the driver to fail probe. > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> on a rk3399-gru-scarlet with no 12v regulator defined and pcie-wifi keeping on working with this patch: Tested-by: Heiko Stuebner <heiko@xxxxxxxxx> Change itself also looks correct, Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx> Thanks for doing that cleanup Heiko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
