On Mon, Aug 5, 2019 at 6:00 PM Kever Yang <kever.yang@xxxxxxxxxxxxxx> wrote: > > > On 2019/7/29 下午3:46, Jagan Teki wrote: > > Print the reason for reset instead of storing it into > > env variable in rk3288. > > > > This would help to find the reset reason directly > > on U-Boot proper logs. > > > > Cc: Wadim Egorov <w.egorov@xxxxxxxxx> > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > --- > > arch/arm/mach-rockchip/rk3288-board.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-rockchip/rk3288-board.c b/arch/arm/mach-rockchip/rk3288-board.c > > index d3ec141fea..613264d7ee 100644 > > --- a/arch/arm/mach-rockchip/rk3288-board.c > > +++ b/arch/arm/mach-rockchip/rk3288-board.c > > @@ -72,7 +72,7 @@ static void rk3288_detect_reset_reason(void) > > reason = "unknown reset"; > > } > > > > - env_set("reset_reason", reason); > > + printf("Reset cause: %s\n", reason); > > > Why this need to set as env before? I didn't touch this code when I migrate Don't know the proper reason for this, ie why I have CCed Wadim. Wadim, any comments? _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip