Re: [PATCH v3 36/57] ram: rk3399: Configure soc odt support

[Kever Yang <kever.yang@xxxxxxxxxxxxxx>]

On 2019/7/16 下午7:57, Jagan Teki wrote:
> CTL 145, 146, 159, 160 registers are used to configure
> soc odt on rk3399.
>
> These soc odt values are updated from CS0_MR22_VAL and
> CS1_MR22_VAL and for lpddr4 these values ORed with
> tsel_rd_select_n.
>
> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: YouMin Chen <cym@xxxxxxxxxxxxxx>

Reviewed-by: Kever Yang <Kever.yang@xxxxxxxxxxxxxx>

Thanks,
 - Kever
> ---
>   drivers/ram/rockchip/sdram_rk3399.c | 49 ++++++++++++++++++++++++++++-
>   1 file changed, 48 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
> index c38ea1d284..e0be9d2485 100644
> --- a/drivers/ram/rockchip/sdram_rk3399.c
> +++ b/drivers/ram/rockchip/sdram_rk3399.c
> @@ -40,6 +40,8 @@
>   #define PHY_SLEWP_EN		0x1
>   #define PHY_SLEWN_EN		0x1
>   #define PHY_RX_CM_INPUT		0x1
> +#define CS0_MR22_VAL		0
> +#define CS1_MR22_VAL		3
>   
>   #define CRU_SFTRST_DDR_CTRL(ch, n)	((0x1 << (8 + 16 + (ch) * 4)) | \
>   					((n) << (8 + (ch) * 4)))
> @@ -554,7 +556,7 @@ static void set_ds_odt(const struct chan_info *chan,
>   		       const struct rk3399_sdram_params *params, u32 mr5)
>   {
>   	u32 *denali_phy = chan->publ->denali_phy;
> -
> +	u32 *denali_ctl = chan->pctl->denali_ctl;
>   	u32 tsel_idle_en, tsel_wr_en, tsel_rd_en;
>   	u32 tsel_idle_select_p, tsel_rd_select_p;
>   	u32 tsel_idle_select_n, tsel_rd_select_n;
> @@ -562,6 +564,7 @@ static void set_ds_odt(const struct chan_info *chan,
>   	u32 tsel_wr_select_dq_n, tsel_wr_select_ca_n;
>   	u32 tsel_ckcs_select_p, tsel_ckcs_select_n;
>   	struct io_setting *io = NULL;
> +	u32 soc_odt = 0;
>   	u32 reg_value;
>   
>   	if (params->base.dramtype == LPDDR4) {
> @@ -581,6 +584,35 @@ static void set_ds_odt(const struct chan_info *chan,
>   
>   		tsel_ckcs_select_p = io->wr_ckcs_drv;
>   		tsel_ckcs_select_n = PHY_DRV_ODT_34_3;
> +		switch (tsel_rd_select_n) {
> +		case PHY_DRV_ODT_240:
> +			soc_odt = 1;
> +			break;
> +		case PHY_DRV_ODT_120:
> +			soc_odt = 2;
> +			break;
> +		case PHY_DRV_ODT_80:
> +			soc_odt = 3;
> +			break;
> +		case PHY_DRV_ODT_60:
> +			soc_odt = 4;
> +			break;
> +		case PHY_DRV_ODT_48:
> +			soc_odt = 5;
> +			break;
> +		case PHY_DRV_ODT_40:
> +			soc_odt = 6;
> +			break;
> +		case PHY_DRV_ODT_34_3:
> +			soc_odt = 6;
> +			printf("%s: Unable to support LPDDR4 MR22 Soc ODT\n",
> +			       __func__);
> +			break;
> +		case PHY_DRV_ODT_HI_Z:
> +		default:
> +			soc_odt = 0;
> +			break;
> +		}
>   	} else if (params->base.dramtype == LPDDR3) {
>   		tsel_rd_select_p = PHY_DRV_ODT_240;
>   		tsel_rd_select_n = PHY_DRV_ODT_HI_Z;
> @@ -621,6 +653,21 @@ static void set_ds_odt(const struct chan_info *chan,
>   	tsel_wr_en = 0;
>   	tsel_idle_en = 0;
>   
> +	/* F0_0 */
> +	clrsetbits_le32(&denali_ctl[145], 0xFF << 16,
> +			(soc_odt | (CS0_MR22_VAL << 3)) << 16);
> +	/* F2_0, F1_0 */
> +	clrsetbits_le32(&denali_ctl[146], 0xFF00FF,
> +			((soc_odt | (CS0_MR22_VAL << 3)) << 16) |
> +			(soc_odt | (CS0_MR22_VAL << 3)));
> +	/* F0_1 */
> +	clrsetbits_le32(&denali_ctl[159], 0xFF << 16,
> +			(soc_odt | (CS1_MR22_VAL << 3)) << 16);
> +	/* F2_1, F1_1 */
> +	clrsetbits_le32(&denali_ctl[160], 0xFF00FF,
> +			((soc_odt | (CS1_MR22_VAL << 3)) << 16) |
> +			(soc_odt | (CS1_MR22_VAL << 3)));
> +
>   	/*
>   	 * phy_dq_tsel_select_X 24bits DENALI_PHY_6/134/262/390 offset_0
>   	 * sets termination values for read/idle cycles and drive strength



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip