Re: [PATCH v3 04/15] ram: rk3399: Handle pctl_cfg return type

[Kever Yang <kever.yang@xxxxxxxxxxxxxx>]

On 2019/7/16 上午2:20, Jagan Teki wrote:
> Add proper return type handling of pctl_cfg with
> meaningful print statement.
>
> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Kever Yang <Kever.yang@xxxxxxxxxxxxxx>

Thanks,
 - Kever
> ---
>   drivers/ram/rockchip/sdram_rk3399.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
> index c918c2e588..de5d8c1b5f 100644
> --- a/drivers/ram/rockchip/sdram_rk3399.c
> +++ b/drivers/ram/rockchip/sdram_rk3399.c
> @@ -1063,6 +1063,7 @@ static int sdram_init(struct dram_info *dram,
>   	unsigned char dramtype = params->base.dramtype;
>   	unsigned int ddr_freq = params->base.ddr_freq;
>   	int channel;
> +	int ret;
>   
>   	debug("Starting SDRAM initialization...\n");
>   
> @@ -1082,9 +1083,10 @@ static int sdram_init(struct dram_info *dram,
>   		if (channel >= params->base.num_channels)
>   			continue;
>   
> -		if (pctl_cfg(chan, channel, params) != 0) {
> -			printf("pctl_cfg fail, reset\n");
> -			return -EIO;
> +		ret = pctl_cfg(chan, channel, params);
> +		if (ret < 0) {
> +			printf("%s: pctl config failed\n", __func__);
> +			return ret;
>   		}
>   
>   		/* LPDDR2/LPDDR3 need to wait DAI complete, max 10us */



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip