Hi, On Tue, 2019-06-18 at 14:27 +0530, Jagan Teki wrote: > On Tue, Jun 18, 2019 at 1:55 PM Paul Kocialkowski > <paul.kocialkowski@xxxxxxxxxxx> wrote: > > Hi, > > > > On Mon, 2019-06-17 at 15:24 +0800, xieqinick@xxxxxxxxx wrote: > > > From: Nick Xie <nick@xxxxxxxxxx> > > > > Was this tested with SPL support? I don't see DRAM configuration here > > so it seems that it relies on the non-free rockchip loader. > > > > If that is the case, could you please indicate that in the commit > > message? > > > > To maintainers: please do not merge this series before DRAM init and > > SPL support is available for these boards. > > > > It seems that other RK3399 boards were merged without SPL support and > > sofar, I have the feeling that nobody cared to explain how we got into > > this broken situation. Please don't merge any more such board. > > fyi: no rk3399 boards were merged w/o SPL. lpddr4 boards were merged > with TPL-enabled (which was discussed on the threads, if you remember) > with below boot chain. > > rkbin (TPL) -> SPL -> U-Boot proper > > Same case for this board as well. Here is a quote from Philipp Tomsich on the thread we discussed this: " On some boards, there will be no TPL and only a SPL stage that will initialise DRAM (as the move to having TPL on the RK3399 is optional). I agree with Paul that the DRAM init should be part of U-Boot whenever we add new boards and make an open DRAM init a prerequisite. " So even if I frequently confuse SPL and TPL, it doesn't change the fact that no board should be merged without proper DRAM init. Please stop pushing for merging these boards. I'm not sure what we should do about the boards that were merged already without DRAM init, but maybe they should be reverted. Cheers, Paul -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
