> -----Original Message----- > From: Enric Balletbo i Serra [mailto:enric.balletbo@xxxxxxxxxxxxx] > Sent: Thursday, May 23, 2019 9:19 PM > To: Mark Brown <broonie@xxxxxxxxxx>; Eduardo Valentin > <edubezval@xxxxxxxxx>; Elaine Zhang <zhangqing@xxxxxxxxxxxxxx> > Cc: tomeu.vizoso@xxxxxxxxxxxxx; guillaume.tucker@xxxxxxxxxxxxx; > mgalka@xxxxxxxxxxxxx; matthew.hart@xxxxxxxxxx; khilman@xxxxxxxxxxxx; > Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>; Heiko Stuebner > <heiko@xxxxxxxxx>; linux-pm@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-rockchip@xxxxxxxxxxxxxxxxxxx; Zhang, Rui > <rui.zhang@xxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: mainline/master boot bisection: v5.2-rc1-165-g54dee406374c on > rk3288-veyron-jaq > Importance: High > > Hi Mark, > > On 23/5/19 15:12, Mark Brown wrote: > > On Wed, May 22, 2019 at 07:23:09PM -0700, kernelci.org bot wrote: > > > >> Details: https://kernelci.org/boot/id/5ce5984c59b514e6a47a364c > >> Plain log: https://storage.kernelci.org//mainline/master/v5.2-rc1-165- > g54dee406374c/arm/multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE > =y/gcc-8/lab-collabora/boot-rk3288-veyron-jaq.txt > >> HTML log: https://storage.kernelci.org//mainline/master/v5.2-rc1-165- > g54dee406374c/arm/multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE > =y/gcc-8/lab-collabora/boot-rk3288-veyron-jaq.html > >> Result: 28694e009e51 thermal: rockchip: fix up the tsadc pinctrl setting > error > > > > It looks like this issue has persisted for a while without any kind of > > fix happening - given that the bisection has identified this commit as > > causing the regression and confirmed that reverting it fixes shouldn't > > we just revert? My guess would be that there's some error with the > > pinctrl settings in the DT for the board. > > > > After some discussion Heiko sent a patch that reverts the offending commit > one day ago [1] and it's waiting for maintainer to pick-up the patch. > I thought Eduardo will take the patch. But I will apply it and queue it for -rc2 anyway. Thanks, Rui > The reason why we think is best reverting that fix it is explained here [2] > > [1] https://lkml.org/lkml/2019/5/22/467 > [2] https://lkml.org/lkml/2019/4/30/270 > > Thanks, > Enric _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip