On 05/08/2019 11:39 AM, Kever Yang wrote: > > On 05/08/2019 02:21 AM, Jagan Teki wrote: >> Now we have >> - board specific -u-boot.dtsi files for board specific u-boot >> dts changes. >> - soc specific rk3399-u-boot.dtsi for soc specific u-boot >> dts changes. >> >> So, include the rk3399-u-boot-dtsi on respective board -u-boot.dtsi >> and drop the properties which are globally available in rk3399-u-boot.dtsi >> >> Right now rk3399-u-boot.dtsi has sdmmc, spi1 u-boot,dm-pre-reloc >> property and more properties and nodes can be move further based >> on the requirements. >> >> This would fix, the -u-boot.dtsi inclusion for evb, firefly, puma >> boards that was accidentally merged on below commit. >> "rockchip: dts: rk3399: Create initial rk3399-u-boot.dtsi" >> (sha1: e05b4a4fa84b65a0c8873e8f34721741fe2bc09d) >> >> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > Reviewed-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx> Applied to u-boot-rockchip, thanks! > > Thanks, > - Kever >> --- >> arch/arm/dts/rk3399-evb-u-boot.dtsi | 1 + >> arch/arm/dts/rk3399-firefly-u-boot.dtsi | 1 + >> arch/arm/dts/rk3399-gru-bob-u-boot.dtsi | 1 + >> arch/arm/dts/rk3399-gru-u-boot.dtsi | 6 ++++++ >> arch/arm/dts/rk3399-gru.dtsi | 1 - >> arch/arm/dts/rk3399-puma-ddr1600.dts | 1 + >> arch/arm/dts/rk3399-puma.dtsi | 2 -- >> 7 files changed, 10 insertions(+), 3 deletions(-) >> create mode 100644 arch/arm/dts/rk3399-gru-u-boot.dtsi >> >> diff --git a/arch/arm/dts/rk3399-evb-u-boot.dtsi b/arch/arm/dts/rk3399-evb-u-boot.dtsi >> index 7e2c57af22..20910e744b 100644 >> --- a/arch/arm/dts/rk3399-evb-u-boot.dtsi >> +++ b/arch/arm/dts/rk3399-evb-u-boot.dtsi >> @@ -3,4 +3,5 @@ >> * Copyright (C) 2019 Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> >> */ >> >> +#include "rk3399-u-boot.dtsi" >> #include "rk3399-sdram-lpddr3-4GB-1600.dtsi" >> diff --git a/arch/arm/dts/rk3399-firefly-u-boot.dtsi b/arch/arm/dts/rk3399-firefly-u-boot.dtsi >> index eab86bdb30..67b63a8352 100644 >> --- a/arch/arm/dts/rk3399-firefly-u-boot.dtsi >> +++ b/arch/arm/dts/rk3399-firefly-u-boot.dtsi >> @@ -3,4 +3,5 @@ >> * Copyright (C) 2019 Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> >> */ >> >> +#include "rk3399-u-boot.dtsi" >> #include "rk3399-sdram-ddr3-1600.dtsi" >> diff --git a/arch/arm/dts/rk3399-gru-bob-u-boot.dtsi b/arch/arm/dts/rk3399-gru-bob-u-boot.dtsi >> index 9edb8cf841..726f396f32 100644 >> --- a/arch/arm/dts/rk3399-gru-bob-u-boot.dtsi >> +++ b/arch/arm/dts/rk3399-gru-bob-u-boot.dtsi >> @@ -3,4 +3,5 @@ >> * Copyright (C) 2019 Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> >> */ >> >> +#include "rk3399-gru-u-boot.dtsi" >> #include "rk3399-sdram-lpddr3-samsung-4GB-1866.dtsi" >> diff --git a/arch/arm/dts/rk3399-gru-u-boot.dtsi b/arch/arm/dts/rk3399-gru-u-boot.dtsi >> new file mode 100644 >> index 0000000000..7bddc3acdb >> --- /dev/null >> +++ b/arch/arm/dts/rk3399-gru-u-boot.dtsi >> @@ -0,0 +1,6 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/* >> + * Copyright (C) 2019 Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> >> + */ >> + >> +#include "rk3399-u-boot.dtsi" >> diff --git a/arch/arm/dts/rk3399-gru.dtsi b/arch/arm/dts/rk3399-gru.dtsi >> index 4cdb4320b7..ca0fc391b2 100644 >> --- a/arch/arm/dts/rk3399-gru.dtsi >> +++ b/arch/arm/dts/rk3399-gru.dtsi >> @@ -545,7 +545,6 @@ ap_i2c_audio: &i2c8 { >> >> &spi1 { >> status = "okay"; >> - u-boot,dm-pre-reloc; >> >> pinctrl-names = "default", "sleep"; >> pinctrl-1 = <&spi1_sleep>; >> diff --git a/arch/arm/dts/rk3399-puma-ddr1600.dts b/arch/arm/dts/rk3399-puma-ddr1600.dts >> index 337e0eabb4..42763f82d0 100644 >> --- a/arch/arm/dts/rk3399-puma-ddr1600.dts >> +++ b/arch/arm/dts/rk3399-puma-ddr1600.dts >> @@ -6,5 +6,6 @@ >> /dts-v1/; >> >> #include "rk3399-puma.dtsi" >> +#include "rk3399-u-boot.dtsi" >> #include "rk3399-sdram-ddr3-1600.dtsi" >> >> diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi >> index 319a610022..897e0bda85 100644 >> --- a/arch/arm/dts/rk3399-puma.dtsi >> +++ b/arch/arm/dts/rk3399-puma.dtsi >> @@ -647,8 +647,6 @@ >> >> >> &spi1 { >> - u-boot,dm-pre-reloc; >> - >> status = "okay"; >> >> #address-cells = <1>; > > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-rockchip > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip