On Thu, Mar 14, 2019 at 5:20 PM Johan Jonker <jbx6244@xxxxxxxxx> wrote: > > How about RK3066? See/use linux-next. Hi and thanks for the notice. The rest of this mail "addressed" for anyone interested. I've added the dither bits for RK3066 - it doesnt have the bit for Allegro/FRC (sel) which really isnt a problem, but brought up a question for me: Should the code avoid calling vop_reg_write with unsupported registers/bits? I assumed a yes, but based on my tests it already does it on RK3288.. (atleast x/y_mir_en and act_info iirc). This only results in a "Warning: not support reg_name" print in drm debug output, but to me printing warnings during normal operations (even if they're only in debug output) seems wrong. I'll be sending a v3 of the patch after this mail, and i did avoid the unnecessary write for now, but i expect to be changing that line of code :P -- Urja Rannikko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
