I have been using that clk patch since I started initial testing of rk3328 on mainline 4.16 [1] and I cannot remember seeing any real issue with usb2/usb3 (beside usb regulator related issue). The clk patch may have helped with some usb issues that I never experienced :-) [1] https://github.com/Kwiboo/linux-rockchip/commits/rockchip-4.16/drivers/clk/rockchip Regards, Jonas On 2019-03-14 20:24, Peter Geis wrote: > Has anyone tested this since Jonas Karlman's clk patch landed? > I noticed a lot of my USB hotplug issues disappeared when I pulled > that patch in. > Especially since one of the fixes was aclk_usb3otg, since it was > incorrectly defined to usb2's aclk. > > On Thu, Mar 14, 2019 at 3:21 PM Heiko Stübner <heiko@xxxxxxxxx> wrote: >> Hi again :-) >> >> Am Donnerstag, 14. März 2019, 20:08:30 CET schrieb Leonidas P. Papadakos: >>> I must say with my testing, I never really have any disconnects. My >>> drive generally works >> It's not any disconnects, it is really when you unplug the device from >> the root port that the >> >>> Surely it's better that it works somewhat than not at all. >>> Maybe we could include the patches and revert them later if a solution >>> arrises? >>> >>> Or is that against the Linux way of doing things? >> The main issue is >> compatible = "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3"; >> >> because: >> (1) On the devicetree-side you declare that they are compatible which may >> or may not conflict with needed later changes >> (2) On the kernel-driver-side with the current status the rk3328-dwc3 >> will get ignored and rk3399-dwc3 used to bind to the generic dt-dwc3 >> driver. >> From looking at the Rockchip code in the vendor kernel we may very well >> need a separate driver to handle the big issue which creates the issue >> which driver will bind to the dt-node. It will be either the generic one >> binding to the rk3399-dwc3 or the special one binding to rk3328-dwc3. >> And sadly it will probably depend on which module gets loaded first. >> >> And devicetrees are supposed to be backwards compatible so a newer >> kernel should keep working with an old devicetree. >> >> A possible way forward would be to introduce a separate compatible for >> rk3328 (both in the binding doc and the generic dwc3 driver), so that >> we get only a >> compatible = "rockchip,rk3328-dwc3"; >> >> Which then even can move easily into a new driver if necessary without >> causing issues for existing devicetrees. >> >> Heiko >> >> >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@xxxxxxxxxxxxxxxxxxx >> https://nam01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.infradead.org%2Fmailman%2Flistinfo%2Flinux-rockchip&data=02%7C01%7C%7C9a4c35bda0bf40b48ce508d6a8b2bb01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636881882922347560&sdata=GJpD0AQPTcCT0BLjb%2BKKdjSMlPKvniqOxigx5qnOEmA%3D&reserved=0 > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@xxxxxxxxxxxxxxxxxxx > https://nam01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.infradead.org%2Fmailman%2Flistinfo%2Flinux-rockchip&data=02%7C01%7C%7C9a4c35bda0bf40b48ce508d6a8b2bb01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636881882922347560&sdata=GJpD0AQPTcCT0BLjb%2BKKdjSMlPKvniqOxigx5qnOEmA%3D&reserved=0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
