Hello, this series is a followup to my mail claiming that changing the state argument for a caller of pwm_apply_state() is a bad idea. See the commit log for the second patch for the reasoning. The only driver that actually modified the argument is the rockchip driver which howver didn't ensure that struct pwm_device::state is updated accordingly which made pwm_get_state() return the old state. The first patch addresses this by dropping the modification. Best regards Uwe Uwe Kleine-König (2): pwm: rockchip: Don't update the state for the caller of pwm_apply_state() pwm: ensure pwm_apply_state() doesn't modify the state argument drivers/pwm/core.c | 2 +- drivers/pwm/pwm-atmel-hlcdc.c | 2 +- drivers/pwm/pwm-atmel.c | 2 +- drivers/pwm/pwm-bcm-iproc.c | 2 +- drivers/pwm/pwm-cros-ec.c | 2 +- drivers/pwm/pwm-hibvt.c | 2 +- drivers/pwm/pwm-imx27.c | 2 +- drivers/pwm/pwm-lpss.c | 2 +- drivers/pwm/pwm-meson.c | 2 +- drivers/pwm/pwm-rcar.c | 2 +- drivers/pwm/pwm-rockchip.c | 10 ++-------- drivers/pwm/pwm-stm32-lp.c | 2 +- drivers/pwm/pwm-sun4i.c | 10 ++-------- drivers/pwm/pwm-zx.c | 2 +- include/linux/pwm.h | 4 ++-- 15 files changed, 18 insertions(+), 30 deletions(-) -- 2.20.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip