From: Heiner Kallweit <hkallweit1@xxxxxxxxx> Date: Sun, 3 Mar 2019 19:58:57 +0100 > Currently the Phy driver's link_change_notify callback is called > whenever the state machine is run (every second if polling), no matter > whether the state changed or not. This isn't needed and may confuse > users considering the name of the callback. Therefore let's change > the behavior and call this callback only in case of an actual > state change. > > This requires changes to the at803x and rockchip drivers. > at803x can be simplified so that it reacts on a state change to > PHY_NOLINK only. > The rockchip driver can also be much simplified. We simply re-init > the AFE/DSP registers whenever we change to PHY_RUNNING and speed > is 100Mbps. This causes very small overhead because we do this even > if the speed was 100Mbps already. But this is neglectable and > I think justified by the much simpler code. > > Changes are compile-tested only. > > Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> This is still rotting... I've marked it as deferred in patchwork. This is the kind of patch review and testing scenerio that simply drives me crazy as a maintainer. Patches should never rot. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
