On Mon, Mar 04, 2019 at 10:55:27AM +0000, Fabrizio Castro wrote: > Hello Simon, > > > From: linux-renesas-soc-owner@xxxxxxxxxxxxxxx <linux-renesas-soc-owner@xxxxxxxxxxxxxxx> On Behalf Of Simon Horman > > Sent: 04 March 2019 10:24 > > Subject: Re: [PATCH 08/15] ARM: shmobile: fix a leaked reference by addingmissing of_node_put > > > > On Fri, Mar 01, 2019 at 10:51:27AM +0100, Geert Uytterhoeven wrote: > > > On Fri, Mar 1, 2019 at 9:57 AM Wen Yang <wen.yang99@xxxxxxxxxx> wrote: > > > > The call to of_get_next_child returns a node pointer with refcount > > > > incremented thus it must be explicitly decremented after the last > > > > usage. > > > > > > > > Detected by coccinelle with the following warnings: > > > > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:77:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount > > incremented on line 66, but without a corresponding object release within this function. > > > > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:85:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount > > incremented on line 66, but without a corresponding object release within this function. > > > > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount > > incremented on line 66, but without a corresponding object release within this function. > > > > > > > > Signed-off-by: Wen Yang <wen.yang99@xxxxxxxxxx> > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > Thanks, applied for v5.2. > > I am sorry for commenting on this just a moment after you took the patch, I guess there is a space missing in the title s/addingmissing/adding missing/ ? Is that still fixable? Thanks for noticing, fixed. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
