On 2019-03-01 19:24, Heiko Stuebner wrote: > Hi, > > Am Freitag, 1. März 2019, 18:54:53 CET schrieb Leonidas P. Papadakos: >> This allows for greater max frequency on rk3328 boards, >> increasing performance. >> >> It has been included in Armbian (a linux distibution for ARM boards) >> for a while now without any reported issues >> >> https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1392mhz-opp.patch >> https://github.com/armbian/build/blob/master/patch/kernel/rockchip64-default/enable-1512mhz-opp.patch >> >> Cc: Heiko Stuebner <heiko@xxxxxxxxx> >> Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx >> Signed-off-by: Leonidas P. Papadakos <papadakospan@xxxxxxxxx> >> --- >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> index 84f14b132..18caef3c3 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> @@ -123,6 +123,20 @@ >> opp-microvolt = <1300000>; >> clock-latency-ns = <40000>; >> }; >> + opp-1392000000 { >> + opp-hz = /bits/ 64 <1392000000>; >> + opp-microvolt = <1350000 1350000 1350000>; >> + opp-microvolt-L0 = <1350000 1350000 1350000>; >> + opp-microvolt-L1 = <1325000 1325000 1325000>; > I checked Rockchip's productpage and the chip really seems to be > rated up to 1.5GHz, but you should get rid of opp-microvolt-Lx > options as these are still vendor-specific regarding the leakage > handling. The datasheet at [1] lists Max CPU frequency of A53 as 1.4 Ghz in Table 3-2 Recommended operating condition, is there a newer datasheet that lists 1.5 Ghz as recommended max? [1] http://opensource.rock-chips.com/images/d/d7/Rockchip_RK3328_Datasheet_V1.1-20170309.pdf Regards, Jonas > > While on it, when all microvolt elements are the same, using the > absolute value instead of "preferred min max" saves a bit of space > similar to the other OPPs in the file. > > Thanks > Heiko > >> + clock-latency-ns = <40000>; >> + }; >> + opp-1512000000 { >> + opp-hz = /bits/ 64 <1512000000>; >> + opp-microvolt = <1450000 1450000 1450000>; >> + opp-microvolt-L0 = <1450000 1450000 1450000>; >> + opp-microvolt-L1 = <1425000 1425000 1425000>; >> + clock-latency-ns = <40000>; >> + }; >> }; >> >> amba { >> > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
