On 26/09/18 18:31, Ezequiel Garcia wrote:
On Tue, 2018-09-25 at 13:29 +0200, Joerg Roedel wrote:
On Thu, Aug 30, 2018 at 07:28:32PM -0300, Ezequiel Garcia wrote:
Printing verbosely via WARN macros and friends in interrupt handlers
is strongly discouraged. Drop them and use proper ratelimited
prints.
Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>
---
drivers/iommu/rockchip-iommu.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
This doesn't apply cleanly to v4.19-rc5, can you please base the patch
on that tag, add the Reviewed-by and re-send?
Well, after looking at the latest code, now I'm wondering why Marc
changed the WARN_ON with a WARN_ON_ONCE, instead of a less verbose
ratelimited print.
WARN_ONCE does it exactly once. A rate-limited printk will still spit as
many messages as you want.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
