Re: [PATCH 3/5] mfd: dt-bindings: Add RK809 and RK817 device tree bindings document

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23.7.2018 05:19, Tony Xie wrote:
Add device tree bindings documentation for Rockchip's RK809 & RK817 PMIC.

Signed-off-by: Tony Xie <tony.xie@xxxxxxxxxxxxxx>
---
  Documentation/devicetree/bindings/mfd/rk808.txt | 55 +++++++++++++++++++++++++
  1 file changed, 55 insertions(+)


Hi Tony,
Seems something went wrong with your series. The introductory email can be
found only in linux-arm-kernel list but nowhere else and I can not find
the fifth patch at all.

Formal notes to this patch.
- Documentation/binding patches should go first in your series.
- Subject line should be: "dt-bindings: mfd: ..."
- Try to avoid the words [documentation, device tree, bindings] in subject.

See this patch [1] from Rob and add him to the recipients for v2.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=44acf10587907ff77c28fd97906220b2d8eb4f05

Best regards,
Michal

diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
index 91b6522..31c9f3d 100644
--- a/Documentation/devicetree/bindings/mfd/rk808.txt
+++ b/Documentation/devicetree/bindings/mfd/rk808.txt
@@ -3,11 +3,15 @@ RK8XX Power Management Integrated Circuit
  The rk8xx family current members:
  rk805
  rk808
+rk809
+rk817
  rk818
Required properties:
  - compatible: "rockchip,rk805"
  - compatible: "rockchip,rk808"
+- compatible: "rockchip,rk809"
+- compatible: "rockchip,rk817"
  - compatible: "rockchip,rk818"
  - reg: I2C slave address
  - interrupt-parent: The parent interrupt controller.
@@ -46,6 +50,28 @@ Optional RK808 properties:
    the gpio controller. If DVS GPIOs aren't present, voltage changes will happen
    very quickly with no slow ramp time.
+Optional RK809 properties:
+- vcc1-supply:  The input supply for DCDC_REG1
+- vcc2-supply:  The input supply for DCDC_REG2
+- vcc3-supply:  The input supply for DCDC_REG3
+- vcc4-supply:  The input supply for DCDC_REG4
+- vcc5-supply:  The input supply for LDO_REG1, LDO_REG2, LDO_REG3
+- vcc6-supply:  The input supply for LDO_REG4, LDO_REG5, LDO_REG6
+- vcc7-supply:  The input supply for LDO_REG7, LDO_REG8, LDO_REG9
+- vcc8-supply:  The input supply for SWITCH_REG1
+- vcc9-supply:  The input supply for DCDC_REG5, SWITCH_REG2
+
+Optional RK817 properties:
+- vcc1-supply:  The input supply for DCDC_REG1
+- vcc2-supply:  The input supply for DCDC_REG2
+- vcc3-supply:  The input supply for DCDC_REG3
+- vcc4-supply:  The input supply for DCDC_REG4
+- vcc5-supply:  The input supply for LDO_REG1, LDO_REG2, LDO_REG3
+- vcc6-supply:  The input supply for LDO_REG4, LDO_REG5, LDO_REG6
+- vcc7-supply:  The input supply for LDO_REG7, LDO_REG8, LDO_REG9
+- vcc8-supply:  The input supply for BOOST
+- vcc9-supply:  The input supply for OTG_SWITCH
+
  Optional RK818 properties:
  - vcc1-supply:  The input supply for DCDC_REG1
  - vcc2-supply:  The input supply for DCDC_REG2
@@ -87,6 +113,28 @@ number as described in RK808 datasheet.
  	- SWITCH_REGn
  		- valid values for n are 1 to 2
+Following regulators of the RK809 PMIC block are supported. Note that
+the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO
+number as described in RK808 datasheet.
+
+	- DCDC_REGn
+		- valid values for n are 1 to 5.
+	- LDO_REGn
+		- valid values for n are 1 to 9.
+	- SWITCH_REGn
+		- valid values for n are 1 to 2.
+
+Following regulators of the RK817 PMIC block are supported. Note that
+the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO
+number as described in RK818 datasheet.
+
+	- DCDC_REGn
+		- valid values for n are 1 to 4.
+	- LDO_REGn
+		- valid values for n are 1 to 9.
+	- BOOST
+	- OTG_SWITCH
+
  Following regulators of the RK818 PMIC block are supported. Note that
  the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO
  number as described in RK818 datasheet.
@@ -99,6 +147,13 @@ number as described in RK818 datasheet.
  	- HDMI_SWITCH
  	- OTG_SWITCH
+There are three pins needed to config, named "gpio_ts" "gpio_gt" "gpio_slp".
+	The gpio_gt and gpio_ts pins support the gpio function.
+	The gpio_slp pin is for controlling the pmic states, as below:
+		- reset
+		- power down
+		- sleep
+
  Standard regulator bindings are used inside regulator subnodes. Check
    Documentation/devicetree/bindings/regulator/regulator.txt
  for more details



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux