Hi Marc On 2018/3/21 1:00, Marc Zyngier wrote: > On 20/03/18 16:52, John Garry wrote: >> On 20/03/2018 16:06, Marc Zyngier wrote: >>> Hi John, >>> >>> On 20/03/18 15:52, John Garry wrote: >>>> On 20/03/2018 13:34, Marc Zyngier wrote: >>>>> On 20/03/18 10:13, JeffyChen wrote: >>>>>> Hi Shawn, >>>>>> >>>>>> On 03/20/2018 05:39 PM, Shawn Lin wrote: >>>>>>> >>>>>>> >>>>>>> Also another patch warns a lot when booting the kernel. Is there >>>>>>> anything else I could do to let it go? Seems I am using broken >>>>>>> dts for requesting IRQ_TYPE_NONE there? >>>>>> >>>>>> could be: >>>>>> https://github.com/torvalds/linux/blob/master/drivers/irqchip/irq-gic-v3.c#L1145 >>>>>> >>>>>> struct irq_fwspec ppi_fwspec = { >>>>>> .fwnode = gic_data.fwnode, >>>>>> .param_count = 3, >>>>>> .param = { >>>>>> [0] = 1, >>>>>> [1] = i, >>>>>> [2] = IRQ_TYPE_NONE, <-- >>>>>> }, >>>>>> }; >>>>>> >>>>>> irq = irq_create_fwspec_mapping(&ppi_fwspec); >>>>> >>>>> Probably is. Caught at my own game, fun! ;-) >>>>> >>>>> Turning that NONE into LEVEL will work, as there is no known PPIs >>>>> configured as edge (specially in a partitioned system), but the general >>>>> case isn't pretty. I'll queue a workaround for now, and will look at >>>>> addressing the more general issue. >>>>> >>>> >>>> JFYI, reverting the original patch mentioned by Shawn resolved the boot >>>> hang I was seeing on my Huawei D03. My D05 was fine without the revert. >>> >>> I guess your D05 doesn't set SCR_EL3.FIQ, meaning that no Group-0 >>> interrupts can reach the firmware. Hopefully it doesn't need them. >>> >>> Would you mind testing the last patch I posted earlier today[1]? >>> >> >> Hi Marc, >> >> Yes, [1] allows my D03 to boot. D05 is still ok. >> >> If you're going to send this same patch to the list then feel free to add: >> Tested-by: John Garry <john.garry at huawei.com> > > OK, thanks for that. There is still a nit on my Chromebook, and I cannot > yet explain why. It works fine now with your updated patch. For rk3399-sapphire-excavator board, Tested-by: Shawn Lin <shawn.lin at rock-chips.com> @Jeffy Could you help test Marc's latest patch on your RK3399 kevin/Gru or whatever Chromebook? > > Digging. > > M. >
