Hi Huang, On 2018/3/15 16:54, Lin Huang wrote: > Assign id PCLK_DDR to pclk_ddr, id HCLK_SD to hclk_sd, so we can > assign frequency for them in dts. I'm curious under which condition that we need assign frequency for hclk_sd? > > Change-Id: I6c4d15d37ddabe4ed34e2351cf26e660672ae9ee > Signed-off-by: Lin Huang <hl at rock-chips.com> > --- > drivers/clk/rockchip/clk-rk3399.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c > index 6847120..a29c99e 100644 > --- a/drivers/clk/rockchip/clk-rk3399.c > +++ b/drivers/clk/rockchip/clk-rk3399.c > @@ -670,7 +670,7 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { > RK3399_CLKGATE_CON(9), 7, GFLAGS, > &rk3399_uart3_fracmux), > > - COMPOSITE(0, "pclk_ddr", mux_pll_src_cpll_gpll_p, CLK_IGNORE_UNUSED, > + COMPOSITE(PCLK_DDR, "pclk_ddr", mux_pll_src_cpll_gpll_p, CLK_IGNORE_UNUSED, > RK3399_CLKSEL_CON(6), 15, 1, MFLAGS, 8, 5, DFLAGS, > RK3399_CLKGATE_CON(3), 4, GFLAGS), > > @@ -886,7 +886,7 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { > RK3399_CLKGATE_CON(31), 8, GFLAGS), > > /* sdio & sdmmc */ > - COMPOSITE(0, "hclk_sd", mux_pll_src_cpll_gpll_p, 0, > + COMPOSITE(HCLK_SD, "hclk_sd", mux_pll_src_cpll_gpll_p, 0, > RK3399_CLKSEL_CON(13), 15, 1, MFLAGS, 8, 5, DFLAGS, > RK3399_CLKGATE_CON(12), 13, GFLAGS), > GATE(HCLK_SDMMC, "hclk_sdmmc", "hclk_sd", 0, >