Hi Heiko,
On 2018/3/2 23:43, Heiko Stuebner wrote:
> Hi Jeffy,
>
> Am Mittwoch, 28. Februar 2018, 13:41:43 CET schrieb Jeffy Chen:
>> Use clk_bulk APIs, and also add error handling for clk enable.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen at rock-chips.com>
>
> [...]
>
>> - for (i = 0; i < clk_cnt; i++) {
>> - clk = of_clk_get(node, i);
>> - if (IS_ERR(clk)) {
>> - error = PTR_ERR(clk);
>> + pd->num_clks = of_count_phandle_with_args(node, "clocks",
>> + "#clock-cells");
>> +
>> + pd->clks = devm_kzalloc(pmu->dev, pd->num_clks * sizeof(pd->clks[0]),
This doesn't work for rk3399, as the pd_vio doesn't have any clocks
attached.
[ 0.713241] rockchip-pm-domain
ff310000.power-management:power-controller: failed to handle node
pd_vio: -12
[ 0.714615] rockchip-pm-domain: probe of
ff310000.power-management:power-controller failed with error -12
I think Jeffy's v2 is coming, so I assume you will drop this version?
>
> applied for 4.17, after changing to devm_kcalloc like below:
>
> pd->clks = devm_kcalloc(pmu->dev, pd->num_clks, sizeof(*pd->clks),
>
>
> Thanks
> Heiko
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
>
>
