Hi Heiko, ? 2018?06?14? 16:30, Heiko St?bner ??: > Am Donnerstag, 14. Juni 2018, 10:14:31 CEST schrieb David Wu: >> Hi Heiko, >> >> ? 2018?06?14? 15:54, Heiko St?bner ??: >>> I don't see that new clock documented in the dt-binding. >>> Also, which clock from the clock-controller does this connect to? >> >> The clock is the "SCLK_GMAC_RMII" at the clock-controller, which could >> be set rate by the link speed. > > Hmm, while these huge number of clocks are somewhat strange, > shouldn't it be named something with _rmii instead of _speed then? Okay, it is better to be named _speed. > > Also, I don't see any clk_enable action for that new clock, so you could > end up with being off? The new speed is the parent of the clk_tx_rx, to enable/disable clk_tx_rx, the new clock would be also enabled/disabled. > > And someone could convert the driver to use the new clk-bulk APIs [0], > so the large number of clk_prepare_enable calls would be a bit > trimmed down. > > > Heiko > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/clk-bulk.c > > > > >
