Hi Robin, On 01/18/2018 08:27 PM, Robin Murphy wrote: >> > > Is it worth using the clk_bulk_*() APIs for this? At a glance, most of > the code being added here appears to duplicate what those functions > already do (but I'm no clk API expert, for sure). right, i think it's doable, the clk_bulk APIs are very helpful. i think we didn't use that is because this patch were wrote for the chromeos 4.4 kernel, which doesn't have clk_bulk yet:) will do it in the next version, thanks. > > Robin.