On Wed, Jan 17, 2018 at 4:14 PM, JeffyChen <jeffy.chen at rock-chips.com> wrote: > Hi Tomasz, > > On 01/17/2018 01:26 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen <jeffy.chen at rock-chips.com> >> wrote: >>> >>> It's hard to undo bus_set_iommu() in the error path, so move it to the >>> end of rk_iommu_probe(). >> >> >> Does this work fine now? I remember we used to need this called in an >> early initcall for all the ARM/ARM64 DMA stuff to work. >> > yes, i think it works now, i saw there are some other iommu drivers also do > this(arm-smmu-v3, mtk_iommu) :) Okay, if so: Reviewed-by: Tomasz Figa <tfiga at chromium.org> Best regards, Tomasz P.S. Looks like your email client is set to HTML messages. Your messages might end up dropped from the mailing list.