On Wed, Jan 17, 2018 at 1:23 PM, Tomasz Figa <tfiga at chromium.org> wrote: > On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen <jeffy.chen at rock-chips.com> wrote: >> It's not safe to unbind rockchip IOMMU driver. > > Might be good to explain why it is not safe and actually add that it > does not make any sense for such low level devices. Actually, shouldn't we also remove support for .remove() and module exit? I don't think it's actually feasible to unload this driver. We actually even have ROCKCHIP_IOMMU Kconfig entry defined as bool, so the driver can be only built-in. Best regards, Tomasz