Hi Brian,
On 2018?01?09? 09:56, Brian Norris wrote:
> On Tue, Jan 09, 2018 at 09:45:05AM +0800, Shunqian Zheng wrote:
>> On 2018?01?09? 03:17, Brian Norris wrote:
>>> On Mon, Jan 08, 2018 at 01:48:51PM +0800, Shunqian Zheng wrote:
>>>> + test_clkout2: test-clkout2 {
>>>> + rockchip,pins =
>>>> + <0 8 RK_FUNC_3 &pcfg_pull_none>;
>>> Your function indexing is a little confusing to me, but one or more of
>>> your datasheet, TRM, or patch are incorrect here. The datasheet says
>>> "Func 3" (which is 1-indexed, so really means RK_FUNC_2) should be
>>> TEST_CLKOUT2, but your TRM agrees with the patch, saying
>>> 2'b11=test_clkout2. So I think your patch is correct, but the datasheet
>>> needs updated?
>> Yeah, please follow the TRM.
> Can you make sure the datasheet gets updated?
Sure, I've sent notification to the owner of datasheet.
Thank you
>
> Thanks,
> Brian
>
>
>
