Hi Jeffy, On Wed, Feb 28, 2018 at 12:11 PM, Jeffy Chen <jeffy.chen at rock-chips.com> wrote: > Currently we are adding all of the attached devices' clocks as pm clocks > and enable them when powering on the power domain. > > This seems unnecessary, because those clocks are already controlled in > the devices' drivers with better error handling. > > Tested on my chromebook minnie(rk3288) and chromebook kevin(rk3399). > > Signed-off-by: Jeffy Chen <jeffy.chen at rock-chips.com> Thanks for your patch! Just wondering: so you prefer to handle the clocks explicitly in all drivers, instead of delegating this task to Runtime PM? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds