Hi, On Wed, Sep 6, 2017 at 1:52 PM, Douglas Anderson <dianders at chromium.org> wrote: > Calculate the calibration code as per the docs. The docs talk about > reading and averaging the pullup and pulldown calibration codes. They > also talk about adding in some adjustment codes. Let's do what the > docs say. > > In practice this doesn't seem to matter a whole lot. On a device I > tested the pullup and pulldown codes were nearly the same (0x23 and > 0x24) and the adjustment codes were 0. > > Reviewed-by: Chris Zhong <zyw at rock-chips.com> > Signed-off-by: Douglas Anderson <dianders at chromium.org> > --- > > drivers/phy/rockchip/phy-rockchip-typec.c | 28 +++++++++++++++++++--------- > 1 file changed, 19 insertions(+), 9 deletions(-) > > diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c > index b8696a7c45fb..e59983a82dcc 100644 > --- a/drivers/phy/rockchip/phy-rockchip-typec.c > +++ b/drivers/phy/rockchip/phy-rockchip-typec.c > @@ -194,6 +194,7 @@ > /* Use this for "n" in macros like "_MULT_XXX" to target the aux channel */ > #define AUX_CH_LANE 8 > > + Not sure how I missed that this was adding a blank line here. :( If there are no other issues I'm happy to re-post or happy if this blank line is removed when the patch is applied. Please let me know which you'd prefer. -Doug
