Hi Ulf, On 2017/10/30 19:40, Ulf Hansson wrote: > On 12 October 2017 at 22:11, Douglas Anderson <dianders at chromium.org> wrote: >> Recently we landed 03de19212ea3 ("mmc: dw_mmc: introduce timer for >> broken command transfer over scheme"). I found a bunch of problems >> with that patch, so this series attempts to solve some of them. >> >> This also fixes the DTO timer in some of the same ways even though I >> haven't personally seen problems with the DTO timer. >> >> NOTE: this series has only been lighly tested so far. I can at least >> reproduce the need for the CTO timer on one of my devices and so I can >> confirm that part still works. As mentioned in the 3rd patch I also >> ran the mmc_test kernel module on this and did manage to see the 3rd >> patch doing something useful. >> >> Changes in v2: >> - Removed extra "int i" >> - Fix the DTO timeout calculation new for v2 >> - Cleanup the DTO timer new for v2 >> >> Douglas Anderson (5): >> mmc: dw_mmc: cancel the CTO timer after a voltage switch >> mmc: dw_mmc: Fix the CTO timeout calculation >> mmc: dw_mmc: Add locking to the CTO timer >> mmc: dw_mmc: Fix the DTO timeout calculation >> mmc: dw_mmc: Cleanup the DTO timer like the CTO one >> >> drivers/mmc/host/dw_mmc.c | 162 +++++++++++++++++++++++++++++++++++++++++----- >> 1 file changed, 146 insertions(+), 16 deletions(-) >> > > Douglas, Jaehoon, > > I decided to pick patch 1->4 for fixes and the patch 5 for next, that > should help us to get them more tested, while Jaehoon is still > catching up. > > I can add ack/drop patches for yet a couple of days this week. Patch 4 introduce a warning: warning: unused variable ?irqflags? [-Wunused-variable] irqflags should be introduced in patch 5 in the same place. As it seems patch 5 will be candidate for 4.15, so could you please help fix patch 4 and 5 manually? Or Doug need to resend patch 4 and 5? > > Kind regards > Uffe > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >