On 16.10.2017 12:06, Jeffy Chen wrote: > From: Tomasz Figa <tfiga at chromium.org> > > The driver that instantiates the bridge should own the drvdata, as all > driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also > owned by its driver struct. Moreover, storing two different pointer > types in driver data depending on driver initialization status is barely > a good practice and in fact has led to many bugs in this driver. > > Let's clean up this mess and change Analogix entry points to simply > accept some opaque struct pointer, adjusting their users at the same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa <tfiga at chromium.org> > Signed-off-by: Jeffy Chen <jeffy.chen at rock-chips.com> Thanks for making it a bit saner. Reviewed-by: Andrzej Hajda <a.hajda at samsung.com> ?-- Regards Andrzej