On 10 October 2017 at 11:33, Heiko Stuebner <heiko at sntech.de> wrote: > Am Montag, 9. Oktober 2017, 20:40:28 CEST schrieb Emil Renner Berthing: >> Adding the linux,gpio-keymap entry also has >> the side-effect of making the driver register >> the touchpad as a touchpad rather than another >> touchscreen. >> >> The index for BTN_LEFT was found by trial and error. >> >> Signed-off-by: Emil Renner Berthing <kernel at esmil.dk> > > looks good to me. I'll just give the ChromeOS people a chance to > respond before applying [maybe they can even tell what the other > keys are :-) ] Good plan. As far as I can tell their kernel doesn't send anything but BTN_LEFT either. It's just that the controller supports multiple buttons, but not all are necessarily connected to any button. Their version of the driver has logic to detect the proper keymap whereas the mainline driver gets it from this devicetree entry. /Emil
