? 2017/10/9 21:05, Rob Herring ??: > On Mon, Oct 9, 2017 at 3:06 AM, Sandy Huang <hjc at rock-chips.com> wrote: >> Hi rob, >> Thanks for your reply. >> >> ? 2017/10/4 5:56, Rob Herring ??: >>> >>> On Fri, Sep 22, 2017 at 11:00:26AM +0800, Sandy Huang wrote: >>>> >>>> This path add support rv1108 rgb output interface driver. >>>> >>>> Signed-off-by: Sandy Huang <hjc at rock-chips.com> >>>> --- >>>> Changes in v2: >>>> 1. rename rockchip,rgb-mode to rgb-mode; >>> >>> >>> You can't just drop the vendor. This needs to be documented in a common >>> place that others will find and use. See panel-common.txt or >>> panel-dpi.txt. >>> >>> Alternatively, you could just drop it and let the panel compatible imply >>> what the mode is. >>> >>> >> ok, get it, i will move the rgb-mode to panel and describe it at >> panel-rgb.txt. the patches will be send soon later. > > Don't create yet another common panel file. We already have > panel-dpi.txt which is for digital parallel interface. > The panel-rgb.txt define different rgb output format and timing, this is the detail info: https://patchwork.kernel.org/patch/9992241/ do you think this need move to panel-dpi.txt? > Rob > > >
