On Sat, 24 Jun 2017, Paul E. McKenney wrote:
> On Sat, Jun 24, 2017 at 11:56:11AM +0200, Thomas Gleixner wrote:
> > static DECLARE_WAIT_QUEUE_HEAD(wakeup_count_wait_queue);
> >
> > +static struct srcu_struct wakeup_srcu;
>
> I suggest this to avoid the need for boot-time init_srcu_struct():
>
> DEFINE_STATIC_SRCU(wakeup_srcu);
Now I know why I had this nagging feeling, that should stay away from
computers yesterday morning.....
> > static struct wakeup_source deleted_ws = {
> > .name = "deleted",
> > .lock = __SPIN_LOCK_UNLOCKED(deleted_ws.lock),
> > @@ -198,7 +200,7 @@ void wakeup_source_remove(struct wakeup_
> > spin_lock_irqsave(&events_lock, flags);
> > list_del_rcu(&ws->entry);
> > spin_unlock_irqrestore(&events_lock, flags);
> > - synchronize_rcu();
> > + synchronize_srcu(&wakeup_srcu);
> > }
> > EXPORT_SYMBOL_GPL(wakeup_source_remove);
>
> The uses of RCU in device_wakeup_arm_wake_irqs() and
> device_wakeup_disarm_wake_irqs() are unrelated and thus do not
> need to be converted? Or am I looking at the wrong version of
> the kernel? (Looking at f65013d655ac ("Merge branch 'for-linus' of
> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace")
> in Linus's tree.)
No, you are looking at the result of heat induced brain melt. Will send a
proper one soon.
Thanks,
tglx
