On Fri, Jun 16, 2017 at 06:57:30AM +0200, Christophe JAILLET wrote: > Le 15/06/2017 ? 19:20, Mark Brown a ?crit : > > if (!of_property_read_u32(node, "rockchip,playback-channels", &val)) { > > if (val >= 2 && val <= 8) > > soc_dai->playback.channels_max = val; > ... and 'err' should be 'ret'... > I'm really confused for such a ugly proposal ! In a situation like this it's generally best to send a patch, I'll fix though. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20170616/09fc6b51/attachment.sig>