Hi Florian, ? 2017/7/28 0:51, Florian Fainelli ??: >> +} >> + >> +static int rockchip_internal_phy_config_init(struct phy_device *phydev) >> +{ >> + int val; >> + >> + /* >> + * The auto MIDX has linked problem on some board, >> + * workround to disable auto MDIX. >> + */ > If this a board-specific problem you may consider register a PHY fixup > for the affected boards, or introduce a specific property to illustrate > that MDI-X is broken. You mean is that if I need disable Auto-mdix, then I'm going to add a property to DTS, from here to decide whether or not to close Auto-mdix? >