Hi, On Mon, Oct 10, 2016 at 01:04:01PM -0700, Brian Norris wrote: > Hi Doug, > > On Mon, Oct 10, 2016 at 11:47:57AM -0700, Doug Anderson wrote: > > + end = ktime_get(); > > + elapsed = ktime_to_us(ktime_sub(end, start)); > > + } while (elapsed < min); > > I think Andreas had similar comments, but it seemed to me like > ktime_before() might be nicer. But (as Andreas did) you might get into > (premature?) micro-optimizations down that path, and I'm certainly not > an expert there. I'd justify it this way: orientation/type of input data is rather irrelevant - all that matters is how you want to treat things in your *inner handling* - and if that happens to be ktime-based (as is usually - if not pretty much always - the case within kernel code), then it ought to be that way, *consistently* (to avoid conversion transition overhead). Andreas Mohr
