? 2016/10/10 10:10, Jaehoon Chung ??: > Hi Shawn, > > On 10/09/2016 10:58 PM, Shawn Lin wrote: >> Hi Jaehoon and Ulf, >> >> This patch is gonna support runtime PM for dw_mmc. >> It could support to disable ciu_clk by default and disable >> biu_clk if the devices are non-removeable, or removeable >> with gpio-base card detect. >> >> Then I remove the system PM since the runtime PM actually >> does the same thing as it. So I help migrate the dw_mmc variant >> drivers to use runtime PM pairs and pm_runtime_force_*. Note >> that I only enable runtime PM for dw_mmc-rockchip as I will >> leave the decision to the owners of the corresponding drivers. >> I just tested it on my RK3288 platform with linux-next to make >> the runtime PM and system PM work fine for my emmc, sd card and >> sdio. But I don't have hardware to help test other variant drivers. >> But in theory it should work fine as I mentioned that the runtime >> PM does the same thing as system PM except for disabling ciu_clk >> aggressively which should not be related to the variant hosts. > > I'm testing this patchset with exynos SoCs. If it's possible to use other SoCs, Thanks for testing this patchset, I will respin v2 if there are no any other nitpick from folkz and regression when you test it. > then I think your patches will be changed more clear than now. > e.g) Not need to define the each driver's runtime_pm_suspend/resume function. > Sure. >> >> As you could see that I just extend the slot-gpio a bit, so the >> ideal way is Ulf could pick them up with Jaehoon's ack. :) >> >> >> >> Shawn Lin (9): >> mmc: dw_mmc: add runtime PM callback >> mmc: dw_mmc-rockchip: add runtime PM support >> mmc: core: expose the capability of gpio card detect >> mmc: dw_mmc-rockchip: disable biu clk if possible >> mmc: dw_mmc-k3: deploay runtime PM facilities >> mmc: dw_mmc-exynos: deploay runtime PM facilities >> mmc: dw_mmc-pci: deploay runtime PM facilities >> mmc: dw_mmc-pltfm: deploay runtime PM facilities > > Maybe s/deploay/deploy Will fix the copy-paste error, mea culpa, but it is quite interesting that checkpatch.pl didn't yell at it. :) > > Best Regards, > Jaehoon Chung > >> mmc: dw_mmc: remove system PM callback >> >> drivers/mmc/core/slot-gpio.c | 8 +++++ >> drivers/mmc/host/dw_mmc-exynos.c | 21 ++++++----- >> drivers/mmc/host/dw_mmc-k3.c | 37 +++++++++---------- >> drivers/mmc/host/dw_mmc-pci.c | 25 ++++++++----- >> drivers/mmc/host/dw_mmc-pltfm.c | 26 ++++++++------ >> drivers/mmc/host/dw_mmc-rockchip.c | 73 ++++++++++++++++++++++++++++++++++++-- >> drivers/mmc/host/dw_mmc.c | 24 ++++++------- >> drivers/mmc/host/dw_mmc.h | 6 ++-- >> include/linux/mmc/slot-gpio.h | 1 + >> 9 files changed, 152 insertions(+), 69 deletions(-) >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Best Regards Shawn Lin
